Review Request: Improve appearance of assistant popup in language support

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107277/#review21841
-----------------------------------------------------------


I very much like the idea to improve the appearance of this widget, but I agree with milian that your initial suggestion is not going to work. It's just too much... in your face. It effectively puts itself in front of half of the code and if I don't want to accept its suggestions (which I quite often don't), then I have to take action and hide it in order to be able to see my code again. So, I'd propose to find a solution which does not require any action when the user does not want to take any of the actions offered.

- Sven Brauch


On Nov. 11, 2012, 3:52 p.m., André Stein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107277/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2012, 3:52 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> I improved (at least IMO) the appearance of the assistant popup while editing code:
> - I changed the layout of the popup to be vertically. Sometimes there are many actions in the popup which gives a rather crowded look. Additionally it sometimes doesn't fit on small screens (at least not on my 13" notebook).
> - The placement has been changed to be oriented at the current cursor's position. The popup is placed 2 lines _under_ the currently edited line. If a line is edited at the bottom of the editor and the popup wouldn't fit into the window, it is placed _above_ the current line. That way a nasty magic number in the code can be removed too.
> 
> All in all I think this gives a better user experience. I had the feeling that some users didn't even see the popup because it was placed at the editor's bottom and so was out of the current "code focus". Additionally the vertical layout matches the behaviour which is seen in other IDEs like Qt Creator or Eclipse.
> 
> 
> Diffs
> -----
> 
>   shell/assistantpopup.h 42c55e4 
>   shell/assistantpopup.cpp 44a4538 
>   shell/uicontroller.cpp 2c0400f 
> 
> Diff: http://git.reviewboard.kde.org/r/107277/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Screenshots
> -----------
> 
> Popup under code
>   http://git.reviewboard.kde.org/r/107277/s/817/
> Popup when space is limited (above)
>   http://git.reviewboard.kde.org/r/107277/s/818/
> 
> 
> Thanks,
> 
> André Stein
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121111/a35bd4d5/attachment.html>