Review Request: Improve appearance of assistant popup in language support

[André Stein]

> On Nov. 11, 2012, 4:12 p.m., André Stein wrote:
> > I do feel up for the task. At least I will have a look at the logic you mentioned.
> > 
> > What do you think about the idea of the light bulb? This would make things easier because we wouldn't need any kind of intelligence where as to show the assistant. Additionnally we wouldn't need any position updates because the user decides when to show the assistant. That way we would solve two things: 
> > 1.) It won't be obstrusive because the users decides to show it 
> > 2.) The assistant won't be limited in the size of actions it could take and could be potentially be replaced by listbox
> > 
> > The workflow could be nearly as fast as the old implementation - one would only need to learn the shortcut to enable the popup.
> 
> Milian Wolff wrote:
>     the lightbulb is a no-go:
>     
>     a) the icon border can be disabled
>     b) it's even less visible than our current implementation, which apparently some people didn't see either
>     c) one has to press some shortcut first before we can see what is actually offered by the assistant

Okay good points. Then let's see what I can do about the points you mentioned before :)


- André


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107277/#review21829
-----------------------------------------------------------


On Nov. 11, 2012, 3:52 p.m., André Stein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107277/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2012, 3:52 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> I improved (at least IMO) the appearance of the assistant popup while editing code:
> - I changed the layout of the popup to be vertically. Sometimes there are many actions in the popup which gives a rather crowded look. Additionally it sometimes doesn't fit on small screens (at least not on my 13" notebook).
> - The placement has been changed to be oriented at the current cursor's position. The popup is placed 2 lines _under_ the currently edited line. If a line is edited at the bottom of the editor and the popup wouldn't fit into the window, it is placed _above_ the current line. That way a nasty magic number in the code can be removed too.
> 
> All in all I think this gives a better user experience. I had the feeling that some users didn't even see the popup because it was placed at the editor's bottom and so was out of the current "code focus". Additionally the vertical layout matches the behaviour which is seen in other IDEs like Qt Creator or Eclipse.
> 
> 
> Diffs
> -----
> 
>   shell/assistantpopup.h 42c55e4 
>   shell/assistantpopup.cpp 44a4538 
>   shell/uicontroller.cpp 2c0400f 
> 
> Diff: http://git.reviewboard.kde.org/r/107277/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Screenshots
> -----------
> 
> Popup under code
>   http://git.reviewboard.kde.org/r/107277/s/817/
> Popup when space is limited (above)
>   http://git.reviewboard.kde.org/r/107277/s/818/
> 
> 
> Thanks,
> 
> André Stein
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121111/7ac42626/attachment.html>