Review Request: Git support: take care of submodule directories when committing non-recursively (the latter is the default&fixed behavior).

[Ivan Shapovalov]

> On Nov. 11, 2012, 2:40 a.m., Aleix Pol Gonzalez wrote:
> > Well honestly I'm unsure... It's quite a lot of new complexity that doesn't feel like it belongs there, don't you think?

Yes, it's a kind of complex. // TBH, I can't understand why the whole thing with recursion control has been created... Maybe Andreas can say something?

But anyway, as long as we have the said recursion control (and as long as the commits are carried out in non-recursive mode), we need at least this.


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107115/#review21792
-----------------------------------------------------------


On Oct. 29, 2012, 3:06 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107115/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2012, 3:06 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Non-recursive operations in Git are handled by replacing a directory URL with URLs of all files (not directories) inside the given directory.
> This is wrong when a change to a submodule directory (man git-submodule) is involved in commit. Actually, it does not make sense to "commit" all files inside the submodule directory as they are not a part of the parent repository.
> And, actually, the commits are non-recursive by default (this is hardcoded) - so submodules can't be committed via GUI for now.
> 
> So, take list of all submodules in the repository and walk the source URL list copying all submodule items into the target list verbatim prior to invoking the directory->files expansion on the source list.
> 
> 
> Diffs
> -----
> 
>   plugins/git/gitplugin.h 1d13c5c 
>   plugins/git/gitplugin.cpp 56efe2f 
> 
> Diff: http://git.reviewboard.kde.org/r/107115/diff/
> 
> 
> Testing
> -------
> 
> Existing unit-tests and manual testing.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121111/1f68298e/attachment.html>