Review Request: Make kompareprocess don't warn about possible null pointer dereference

[André Stein]

> On Nov. 10, 2012, 11:29 a.m., Sven Brauch wrote:
> > Oh, so the original patch didn't fix an actual crash? Well, then. I had assumed this was the case... :)

Some time ago I had a crash on "Show Differences" using SVN but I unfortunately I don't have a crash dump from back then. And as Clang warned correctly about the possible null pointer dereference using the local context only I thought this code might be related to it. But actually it's just a big false alarm. I edited the review's title to match it's significance :)


- André


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107270/#review21768
-----------------------------------------------------------


On Nov. 10, 2012, 11:39 a.m., André Stein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107270/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2012, 11:39 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This patch prevents a null pointer dereference in kompareprocess.
> 
> 
> Diffs
> -----
> 
>   plugins/patchreview/libdiff2/kompareprocess.cpp fe9a62e 
> 
> Diff: http://git.reviewboard.kde.org/r/107270/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> André Stein
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121110/fa1d07ef/attachment.html>