Review Request: Add a document list context menu button right to main tab bar

[André Stein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107170/#review21711
-----------------------------------------------------------


Something broke during the simplification you just checked in: In documentListActionTriggered a QWidget* is taken from the QVariant while in updateDocumentList a QView is stored in the QAction. A QWidget was saved before but actually that code was a bit obfuscated due to the usage of pairs and key/value objects :/ Anyway we need the QWidget to be saved in the QAction as the Container just accepts Widget as function parameters. That way the registration of View as metadata type can be removed. Unfortunately the current code crashes quite easily and doesn't allow to switch documents by clicking on the popup menu.

Do you submit a fix for taht or should I do that? Depending in your time I could do it but that would mean another review request. I'll try to work on the other things you mentioned in the commit soon.


- André Stein


On Nov. 6, 2012, 2:14 p.m., André Stein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107170/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2012, 2:14 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This request adds a little button to the right of the tab bar. It activates a context menu which shows (in sorted order) all currently open documents and opens the selected document upon click. This is a feature I miss from Visual Studio. I do know that it's redundant to the Documents view panel but I think it allows a quicker access to files - especially when a lot files are open in the IDE. As it is very small button I think it does no harm to users who don't want to use it.
> 
> 
> Diffs
> -----
> 
>   sublime/container.h 1633a9f 
>   sublime/container.cpp 5483029 
> 
> Diff: http://git.reviewboard.kde.org/r/107170/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Screenshots
> -----------
> 
> Button
>   http://git.reviewboard.kde.org/r/107170/s/814/
> Context menu shown on button click
>   http://git.reviewboard.kde.org/r/107170/s/809/
> 
> 
> Thanks,
> 
> André Stein
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121109/b937061d/attachment.html>