Review Request: Add a 10ms timer to scheduling a document for reparsing, and refactor -- fixes slowness when inserting text
Sven Brauch
svenbrauch at gmx.de
Mon Nov 5 17:16:49 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107140/
-----------------------------------------------------------
(Updated Nov. 5, 2012, 5:16 p.m.)
Review request for KDevelop and Milian Wolff.
Description
-------
Add a 10ms timer to scheduling a document for reparsing, and refactor.
This fixes extreme slowness when pasting large parts of text
into the editor.
Also, make DocumentParsePlan targets a set instead of a list.
I wanted to write a unit test benchmark which verifies this but it turns out to be difficult, since you need a KateTextDocument for inserting text, and it's not being installed (the .h file). I thus didn't do that yet.
You can easily test this manually by pasting > 3000 lines into the editor.
Diffs
-----
language/backgroundparser/backgroundparser.cpp 28a4202
language/backgroundparser/documentchangetracker.h e3f7f5c
language/backgroundparser/documentchangetracker.cpp 2aab705
Diff: http://git.reviewboard.kde.org/r/107140/diff/
Testing
-------
Thanks,
Sven Brauch
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121105/cae467f7/attachment.html>
More information about the KDevelop-devel
mailing list