Review Request: Make watched debugger variables user-editable (#257343)
Aleix Pol Gonzalez
aleixpol at gmail.com
Sun Nov 4 18:52:43 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107158/#review21416
-----------------------------------------------------------
I don't really know much about this code-base, but still I don't understand the patch that much.
First of all, why is this patch removing all those files? It may be possible that they're unneeded, but it should be done in a different patch.
debuggers/gdb/gdbvariable.cpp
<http://git.reviewboard.kde.org/r/107158/#comment16636>
Is that really the way to check if it's an editable value?
debuggers/gdb/gdbvariable.cpp
<http://git.reviewboard.kde.org/r/107158/#comment16637>
Is Binary really the only special case?
- Aleix Pol Gonzalez
On Oct. 31, 2012, 4:31 p.m., Enver Haase wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107158/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2012, 4:31 p.m.)
>
>
> Review request for KDevelop and Niko Sams.
>
>
> Description
> -------
>
> Used together with my patch for KDevPlatform.
> Closes https://bugs.kde.org/show_bug.cgi?id=257343
> making watched debugger variables user-editable.
>
>
> This addresses bug 257343.
> http://bugs.kde.org/show_bug.cgi?id=257343
>
>
> Diffs
> -----
>
> debuggers/gdb/_abstractvariableitem.h 9ccdd03
> debuggers/gdb/_abstractvariableitem.cpp 4502393
> debuggers/gdb/_variableitem.h 8285d1f
> debuggers/gdb/_variableitem.cpp 4cd3921
> debuggers/gdb/_watchitem.h 3e26038
> debuggers/gdb/_watchitem.cpp 83eecd3
> debuggers/gdb/gdbvariable.h 9a6fb11
> debuggers/gdb/gdbvariable.cpp a98e25d
>
> Diff: http://git.reviewboard.kde.org/r/107158/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Enver Haase
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121104/5e1a8889/attachment.html>
More information about the KDevelop-devel
mailing list