Review Request: Cleanup of template preview

[Miha Čančula]

> On Nov. 1, 2012, 3 p.m., Milian Wolff wrote:
> > Yep, much better already. Please push it to master.
> > 
> > But there is more stuff for the future, as I said - esp. the automatic deduction of project/file template type from a .desktop file. 
> > 
> > Furthermore, the toolview shouldn't do anything (esp. nothing as expensive as reading the whole text document) when it is hidden. Can you ensure that it is following that principle? I.e. if hidden -> don't do any updates. If it gets shown -> ensure updates are applied.
> > 
> > Cheers

Before I make a mess again: is it better to have 10 small commits, or should I squash them and submit this as one commit?


- Miha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107163/#review21302
-----------------------------------------------------------


On Nov. 2, 2012, 10:46 a.m., Miha Čančula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107163/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2012, 10:46 a.m.)
> 
> 
> Review request for KDevelop and Milian Wolff.
> 
> 
> Description
> -------
> 
> Cleans up and prettifies the template preview toolview. 
> 
> - No more temporary files are used, only a single KTextEditor::Document with changing contents.
> - TemplateRenderer::render() and friends no longer append error string to its output. Instead, errors are reported by a separate method. 
> - In the template preview, these errors are reported in a KMessageWidget at the top.
> - Notifications that the current document is not a template is displayed in the same message widget, as information. 
> 
> 
> Diffs
> -----
> 
>   language/codegen/templaterenderer.h ab904237a19b10942e73e24d7ece58a9b9a2e27f 
>   language/codegen/templaterenderer.cpp 9cc9574ccc741fa32a67bd38f85c962e43f2cbba 
>   plugins/filetemplates/templatepreview.h 2c85660d3451869881cc1883f9e7e78968b9fad2 
>   plugins/filetemplates/templatepreview.cpp a3fa44a57fe07c3adce437a86b6e03aeeeecb046 
>   plugins/filetemplates/templatepreview.ui 7ee0b11886d62c622c908497a763bcb6dbf544e2 
> 
> Diff: http://git.reviewboard.kde.org/r/107163/diff/
> 
> 
> Testing
> -------
> 
> Tested locally with a handful of template and non-template files. 
> 
> 
> Screenshots
> -----------
> 
> Preview of a correct template
>   http://git.reviewboard.kde.org/r/107163/s/806/
> Error reporting
>   http://git.reviewboard.kde.org/r/107163/s/807/
> 
> 
> Thanks,
> 
> Miha Čančula
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121102/04753b62/attachment.html>