Review Request: Make it easier to reach buttons on the edges

Aleix Pol Gonzalez aleixpol at gmail.com
Thu May 31 14:07:26 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101506/#review14304
-----------------------------------------------------------

Ship it!


Just tried it, I think it's useful. I'd say go in. :)

I'm unsure Alex understood what was going on (Aurélien had to tell me twice at least :P).

- Aleix Pol Gonzalez


On June 4, 2011, 3:10 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101506/
> -----------------------------------------------------------
> 
> (Updated June 4, 2011, 3:10 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> When KDevelop window is maximized, the buttons on the left and right edges of the window could be easier to reach. Right now there is a 2 pixel gap between the button and the border, which makes it impossible to reach the button by throwing the mouse to the edge.
> 
> Attached simple patch just set the margin to 0. I am not sure however if it makes sense to keep the define if it is set to 0. If you prefer me to get rid of the define and replace its usage with plain 0, tell me.
> 
> 
> Diffs
> -----
> 
>   sublime/ideallayout.h 06adbe7 
> 
> Diff: http://git.reviewboard.kde.org/r/101506/diff/
> 
> 
> Testing
> -------
> 
> See attached before/after screenshot.
> 
> 
> Screenshots
> -----------
> 
> Before - After
>   http://git.reviewboard.kde.org/r/101506/s/174/
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120531/7d03934f/attachment.html>


More information about the KDevelop-devel mailing list