Review Request: Look for ext/hash_map and unordered_map instead of checking gcc's version.

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105067/
-----------------------------------------------------------

(Updated May 28, 2012, 5:40 p.m.)


Review request for KDevelop and Milian Wolff.


Changes
-------

Reordered the ifdef checks in parser.h


Description
-------

Look for ext/hash_map and unordered_map instead of checking gcc's version.

Follow-up to commits 9f8e8f662974a1035ea64f0ab9404b8858a02a57 and
5c59bd61b1df1b963959f086c5202689c084e0f3. The decision of whether to
include <ext/hash_map> or <unordered_map> for gcc/clang was based on
whether gcc > 4.3 was installed or whether clang was being used. The
latter implicitly assumed a recent enough libstdc++ version (ie. >=
4.3) was being used, which might not be the case on systems such as
FreeBSD and possibly OS X.

Instead of checking for compiler versions, we now look for these
headers: CMake first detects whether <unordered_map> is present and,
in case it is not, it looks for <ext/hash_map>. The checks in
languages/cpp/parser/parser.h have been updated as well. This should
cover all the cases being previously detected, as well as fix the
checks for FreeBSD and other systems where the build was failing
before with clang.


Diffs (updated)
-----

  CMakeLists.txt 8a3be2181642d0af6e3660d52948bd24d3f8cb4a 
  config.h.cmake 0c41fe4203dc39f4ff1e03b8b77211c7148a9bec 
  languages/cpp/CMakeLists.txt 1577a7baffc3af052c62a075eced8d09750fdf53 
  languages/cpp/parser/parser.h c5198912bbf83a46bc89b1595d68b71e0a9b7df4 

Diff: http://git.reviewboard.kde.org/r/105067/diff/


Testing
-------

Was able to build KDevelop with clang and libstdc++ 4.2.1 on FreeBSD. I would appreciate if people could test this patch on Linux with a more recent libstdc++


Thanks,

Raphael Kubo da Costa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120528/ab932fbf/attachment.html>