Review Request: Added nested view in the class browser plugin.

[Ghislain Mary]

> On May 23, 2012, 7:44 p.m., Milian Wolff wrote:
> > generally a nice idea I think it could be useful to some people
> > 
> > as you'll see below, there are some issues though, esp. if you open large projects.
> > 
> > then it looks like you are currently not storing the setting (whether flat or nested view is shown) in a config file - please do so, such that the user gets the same view when he reopens kdevelop

I improved the patch since, and the setting is now stored ;-)
I will resolve the issues below and submit a new patch.


> On May 23, 2012, 7:44 p.m., Milian Wolff wrote:
> > plugins/classbrowser/classmodel.cpp, line 198
> > <http://git.reviewboard.kde.org/r/104932/diff/1/?file=64186#file64186line198>
> >
> >     please explain this here a bit (i.e. why is this required), and ensure that the viewtype differs from the current viewtype and return early otherwise.

I already handled the early return since this patch. It will be present in the patch to come.
This step is done to update the project trees. It may not be necessary to remove the nodes and add them again but it's the easier way I found to update the project nodes when changing the view type.


> On May 23, 2012, 7:44 p.m., Milian Wolff wrote:
> > plugins/classbrowser/projectfolder.cpp, line 42
> > <http://git.reviewboard.kde.org/r/104932/diff/1/?file=64189#file64189line42>
> >
> >     ugh that looks horribly inefficient - please use the project model instead (since that already knows the parent<->children association
> >

I'll try to use the project model instead.


- Ghislain


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104932/#review14093
-----------------------------------------------------------


On May 13, 2012, 9:43 a.m., Ghislain Mary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104932/
> -----------------------------------------------------------
> 
> (Updated May 13, 2012, 9:43 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> It enables the user to navigate the project tree and list the classes defined in each directory of the project.
> 
> Some more work would be needed after this to improve the search function. I think we should replace the search lineedit by a "Filter..." action as in the projectmanagerview plugin so it is more consistent. And then when the user enters a filter we should use automatically the flat view because otherwise the user will probably not see the result of his filtering.
> 
> 
> This addresses bug 212583.
>     http://bugs.kde.org/show_bug.cgi?id=212583
> 
> 
> Diffs
> -----
> 
>   plugins/classbrowser/classmodel.h fd1eed5 
>   plugins/classbrowser/classmodel.cpp f9956c6 
>   plugins/classbrowser/classwidget.cpp f5a9517 
>   plugins/classbrowser/projectfolder.h d951a86 
>   plugins/classbrowser/projectfolder.cpp 419cb79 
> 
> Diff: http://git.reviewboard.kde.org/r/104932/diff/
> 
> 
> Testing
> -------
> 
> I used it on the kdevplatform and kdevelop sources and have seen no problem.
> 
> 
> Thanks,
> 
> Ghislain Mary
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120524/62399850/attachment.html>