Review Request: Let __builtin_offsetof be used with "struct foo" as type

[Alexandre Courbot]

> On May 12, 2012, 7:29 p.m., Milian Wolff wrote:
> > good patch but please add a unit test (see tests/test_cppcodecompletion.h testPreprocessor)
> > 
> > bye

Sorry but what should be tested here? This patch just adds a pair of missing parentheses...


- Alexandre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104912/#review13747
-----------------------------------------------------------


On May 11, 2012, 5:33 a.m., Alexandre Courbot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104912/
> -----------------------------------------------------------
> 
> (Updated May 11, 2012, 5:33 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> There is a clever macro defined that supports __builtin_offset, but constructs of the form "__builtin_offset(struct foo, member)" would fail with a parse error. This patch adds parentheses around the type to ensure these are supported as well.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/setuphelpers.cpp 23d549e 
> 
> Diff: http://git.reviewboard.kde.org/r/104912/diff/
> 
> 
> Testing
> -------
> 
> Checked it worked, the change is pretty simple.
> 
> 
> Thanks,
> 
> Alexandre Courbot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120513/f7f89026/attachment.html>