Review Request: __attribute__((...)) parsing fixed with MinGW headers

Ivan Shapovalov intelfx100 at
Fri May 4 04:32:16 UTC 2012

This is an automatically generated e-mail. To reply, visit:

(Updated May 4, 2012, 4:32 a.m.)

Review request for KDevelop.


Unit-tests added.


MinGW system headers tend to undefine __attribute__ (which is internally defined to no-op in the KDevelop preprocessor since C++ parser cannot handle it correctly in all cases).

Patch just adds "fixed" property to the definition.
Also, removed from parser some dead code related to __attribute__ parsing, since it handles only one case from possibly infinite number of these.

Diffs (updated)

  languages/cpp/parser/lexer.cpp d097710 
  languages/cpp/parser/parser.cpp 172b6b6 
  languages/cpp/parser/tokens.h 77ab417 
  languages/cpp/parser/tokens.cpp 7df4bb9 
  languages/cpp/setuphelpers.cpp 59bb850 
  languages/cpp/tests/test_cppcodecompletion.cpp eda22f0 



Used it with MinGW and normal system headers, no regressions detected. Unit-tests are passed.

BTW: I couldn't find out how to use the standard preprocessing environment (which has been modified) in preprocessor unit-tests, so no unit-tests added.


Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list