Review Request: Fixed a great part of the Qt classes krazy checks (replace Qt classes that should not be used by there KDE counterparts).

[Milian Wolff]

> On May 2, 2012, 5:54 p.m., Andreas Pakulat wrote:
> > Did you verify wether these changes have any side-effects? in general its often ok to just use the k-classes, butmaybe in some of the cases the use of the Qt version was intentional. A look at the history may also indicate such decisions.

sorry, I also have to reject this review request: I just David Faure and he confirmed that these krazy checks are not up2date in regard to the upcoming Qt5. I quote:

[10:30] <milian> are the krazy checks regarding »"Q*" classes that should be replaced with "K*" classes« up2date in regard to qt5/frameworks?
[10:30] <milian> I'm wondering what to do with https://git.reviewboard.kde.org/r/104823
[10:31] <dfaure> I'm pretty sure they are not
[10:32] <dfaure> milian: I'd reject such changes,  they are going in the wrong direction indeed
[10:32] <milian> ok thanks
[10:32] <dfaure> right now when I look at code that uses KLineEdit or KComboBox (in kdelibs framework) I try to figure out if they really need specific features from these classes, or if Q* would do.
[10:33] <dfaure> and in 5.1 we'll put some of the missing features into Q*.
[10:33] <dfaure> I'll try to remember to ask Allen to disable that krazy check

So, I'm closing this request as discarded. Sorry for taking your time on this Ghislain!


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104823/#review13284
-----------------------------------------------------------


On May 2, 2012, 3:28 p.m., Ghislain Mary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104823/
> -----------------------------------------------------------
> 
> (Updated May 2, 2012, 3:28 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Fixed a great part of the Qt classes krazy checks (replace Qt classes that should not be used by there KDE counterparts).
> 
> 
> Diffs
> -----
> 
>   documentation/documentationview.cpp 53e05a88cc3b0f6b4a06864c82f85540fd7f9243 
>   plugins/appwizard/projectselectionpage.ui 7a33fdd2c68831776ea5dc8d7259afa831854a41 
>   plugins/cvs/cvsgenericoutputview.ui 58a273e4d0967dda949b49be964ba579aa89c5f5 
>   plugins/dashboard/plasmoids/projectfileplasmoid/config.ui d7be64440e21f3e988029d40d299560a50e1f0f9 
>   plugins/execute/projecttargetscombobox.h 154226844e5a3e7f5c40a09bf86ba47d99f5237f 
>   plugins/execute/projecttargetscombobox.cpp 1096093c07408392daef38d6f4e3b2884babc8fd 
>   plugins/externalscript/editexternalscript.ui cd747e649148a941a42f81d5d5553c6a0bfb7957 
>   plugins/git/gitmessagehighlighter.h 5d65e7c9401315b16e8f90c0ce2d49e4f4910814 
>   plugins/git/gitmessagehighlighter.cpp b7239f4274bc2d771f7d9434703fc1d0173f7e92 
>   plugins/git/gitplugin.h eae2bb37582dd3c60af224c14bf4be8d9195bc32 
>   plugins/git/gitplugin.cpp fe88f271acb9ccdd6e9e617e1c98ab6c063cc1b3 
>   plugins/git/stashmanagerdialog.cpp bf0f6a45c54bc10ab28838e8a1712ec8fbf1a34a 
>   plugins/grepview/greputil.h 446286e887cc1b78105f834783cd1c75ab932062 
>   plugins/grepview/greputil.cpp 0447a2655f965ef2f44eb35075a179bd22e4460a 
>   plugins/patchreview/patchreview.ui 06e80bb4a9b207586ef1d6d7d3ec680738498210 
>   plugins/projectmanagerview/projectmanagerviewplugin.cpp 750dded23ee10c3cb0d6e6946967e0d9dcc0f1da 
>   plugins/quickopen/quickopenplugin.cpp e467ad06bf29a9f4a6ec8b9cb71b06cbd3cdf2f5 
>   plugins/snippet/editrepository.ui 2432bb47e4260007c8eef0f7152cb94ca50fbd40 
>   plugins/snippet/snippetcompletionitem.cpp 732900b2f5b76e38dbc715b64b29c207df8a5210 
>   plugins/subversion/ui/ssltrustdialog.ui ffc7e7922683c868670738f1f4611be075a59ab0 
>   shell/projectinfopage.ui d7b1cb83bd98f5cc7476105811438ef8863bacdb 
>   shell/projectsourcepage.ui b87508f6ba625095d4d854d08b8abe37cbc0c1e5 
>   shell/settings/uiconfig.ui 3fb219bc2138ce754f5c1d16e09f88e4ee31d37a 
>   sublime/tests/viewactivationtest.cpp df6d92b267e63c4c1c25e182bd60df927c4e6437 
>   util/ssh_client/main.h 446a1a924c7fa4373c05f213d83cd31f1c82c093 
>   vcs/dvcs/ui/branchmanager.cpp be6e82564f3ec0fe751e2d74e4c5ccfa54a2571d 
>   vcs/dvcs/ui/cvsgenericoutputview.ui 58a273e4d0967dda949b49be964ba579aa89c5f5 
>   vcs/interfaces/ibasicversioncontrol.h 8b47390780889f9d02d652d28932eb5403e2592b 
>   vcs/interfaces/ibasicversioncontrol.cpp fe6003584618d41f56acce389109eda6030ca689 
>   vcs/widgets/vcsdiffpatchsources.h f4be887dfa58c99a648c52320a390daf0d403c0b 
>   vcs/widgets/vcsdiffpatchsources.cpp 9a90af2a1d9e063a417ec54aa2e67e71a345dee4 
>   vcs/widgets/vcseventwidget.ui 09bd430de7f5a21f28bd099deb954d6f665f0db1 
>   debugger/breakpoint/breakpointdetails.h b937a9cd4cb84f8e3e20d791490a1c3bf746ef1f 
>   debugger/breakpoint/breakpointdetails.cpp a3a0fc50fd0cee27c8c8fbb153eadc3287cdd91f 
>   documentation/documentationview.h e577b2fe7c65868b926f25d33456ed52ba87b1f9 
> 
> Diff: http://git.reviewboard.kde.org/r/104823/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ghislain Mary
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120503/ef89de99/attachment.html>