Review Request: Add support for cmake target include_directories.

[Ben Wagner]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104777/
-----------------------------------------------------------

(Updated May 3, 2012, 3:19 a.m.)


Review request for KDevelop.


Changes
-------

Attaching format-patch which reflects the changes in diff 3.


Description
-------

With CMake 2.8.8, it is now possible to write something like

set_property(TARGET zlib APPEND PROPERTY INCLUDE_DIRECTORIES "include/config")

This change implements include directories on targets.

Note that I am not a committer, so if you want it, the diff I uploaded is a format-patch against current master.


This addresses bug 298859.
    http://bugs.kde.org/show_bug.cgi?id=298859


Diffs
-----

  projectmanagers/cmake/cmakemanager.cpp 9ae8f90 
  projectmanagers/cmake/cmakemodelitems.h 705a632 
  projectmanagers/cmake/cmakemodelitems.cpp 957c410 
  projectmanagers/cmake/tests/CMakeLists.txt ca8567e 
  projectmanagers/cmake/tests/cmakemanagertest.h 1316952 
  projectmanagers/cmake/tests/cmakemanagertest.cpp ca3532d 
  projectmanagers/cmake/tests/manual/target_includes/CMakeLists.txt PRE-CREATION 
  projectmanagers/cmake/tests/manual/target_includes/includes/target_include.h PRE-CREATION 
  projectmanagers/cmake/tests/manual/target_includes/main.cpp PRE-CREATION 
  projectmanagers/cmake/tests/manual/target_includes/target_includes.kdev4 PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/104777/diff/


Testing
-------

Built and ran. The test linked from bug works as expected after building (as the test itself generates some of the required .h files). Behavior of non-target includes appears unaffected.


Thanks,

Ben Wagner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120503/d9bea403/attachment.html>