Review Request: Do not force git diff output

[Aleix Pol Gonzalez]

> On March 30, 2012, 10:49 a.m., Aleix Pol Gonzalez wrote:
> > Does the review feature keep working? can you still review your changes before committing?
> > 
> > That you can change it on the .hgrc is not good if the reviewplugin can't understand it!
> 
> Yannick Kiekens wrote:
>     As far as I know everything works as intended.
>     Please specify any aditional tests you would like to see
>     (attached schreenshot showing the Commit Review)

Shouldn't we pass as a parameter the type of diff we need instead of letting the user to choose in .hgrc what it's used, then?

PS: the review's summary is wrong :)


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104440/#review12009
-----------------------------------------------------------


On March 30, 2012, 11:01 a.m., Yannick Kiekens wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104440/
> -----------------------------------------------------------
> 
> (Updated March 30, 2012, 11:01 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Do not force git diff output (-g)
> follow hgrc instead
> 
> Needed to push diff to a reviewboard instance with mercurial backend
> 
> 
> Diffs
> -----
> 
>   mercurialplugin.cpp 59198e8 
> 
> Diff: http://git.reviewboard.kde.org/r/104440/diff/
> 
> 
> Testing
> -------
> 
> diff output can be changed by modifying .hgrc 
> 
> Using this patch an a mercurial project with reviewboard
> 
> 
> Screenshots
> -----------
> 
> Commit Review
>   http://git.reviewboard.kde.org/r/104440/s/500/
> 
> 
> Thanks,
> 
> Yannick Kiekens
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120331/f408741f/attachment.html>