Review Request: Do not force git diff output

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104440/#review12009
-----------------------------------------------------------


Does the review feature keep working? can you still review your changes before committing?

That you can change it on the .hgrc is not good if the reviewplugin can't understand it!

- Aleix Pol Gonzalez


On March 30, 2012, 10:24 a.m., Yannick Kiekens wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104440/
> -----------------------------------------------------------
> 
> (Updated March 30, 2012, 10:24 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Do not force git diff output (-g)
> follow hgrc instead
> 
> Needed to push diff to a reviewboard instance with mercurial backend
> 
> 
> Diffs
> -----
> 
>   mercurialplugin.cpp 59198e8 
> 
> Diff: http://git.reviewboard.kde.org/r/104440/diff/
> 
> 
> Testing
> -------
> 
> diff output can be changed by modifying .hgrc 
> 
> Using this patch an a mercurial project with reviewboard
> 
> 
> Thanks,
> 
> Yannick Kiekens
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120330/11db6fd9/attachment.html>