Review Request: Fix kde4workspace-processui linker error on gentoo linux

[Milian Wolff]

> On July 22, 2011, 9:29 a.m., Andreas Pakulat wrote:
> > This is wrong in all ways possible. Gentoo should just stop trying to break up packages which where never meant to be broken into pieces.
> > 
> > Anyway, at least a find_library call is necessary for this so CMake knows the absolute path to the processui library.
> 
> Andreas Pakulat wrote:
>     An even better fix would be to make the usage of the process-ui library optional and use the old simple process widget instead when its missing.
> 
> Sven Brauch wrote:
>     I'm aware of the fact that this isn't a clean fix, but I think the problem should be adressed somehow, so I suggested this.
>     
>     Okay, so what would you suggest instead? Compiling the tests could just be skipped if that library isn't present, if you think that's a better solution.
> 
> Andreas Pakulat wrote:
>     If you want to address the problem, then get the Gentoo maintainers to fix the config-module that is installed for kde-workspace. Thats a tough job though, been there and failed ;)
>     
>     Adding a workaround to kdevelop is fine, but then at least find_library needs to be used to find the library if the config module is broken and does not provide the variables, so cmake knows the actual library and can generate proper dependencies and linking does not fail if for some reason the processui library is not in /usr/lib.
>     
>     The library is not only used for the tests but also for the gdb plugin itself, so making it optional means providing a suitable replacement. Before the dependency on processui was introduced we had our own widget to show the list of processes and select one to attach to, that should still be findable in the history and hence could be resurrected.
> 
> Andreas Pakulat wrote:
>     PS: Just to clarify, since I now realize I'm blaming this just on Gentoo: The problem is caused by a mismatch between what Gentoo packagers want and what the kde-workspace module's cmake files and CMake itself offers. I've talked to gentoo packagers some time ago about this and there's basically no easy way to solve this - one would involve adjust cmake, another would be splitting up kde-workspace libs into separate pieces and the third one was to actually move the processui libs into kdelibs as the maintainer promised 2 or 3 years ago. None of that is realistic to happen at this point unfortunately.
> 
> Sven Brauch wrote:
>     Okay :)
>     Hmm, how could you do that with find_library? Isn't the core of the problem that cmake gets the actual name of the library wrong? At least "find_library(KDE4WORKSPACE_PROCESSUI_LIBS processui)" or similar also returns the faulty lib name.
> 
> Andreas Pakulat wrote:
>     Thats probably because KDE4WORKSPACE_PROCESSUI_LIBS is already set, find_library will not do anything when the target variable is already set. So use find_library with a different name for the variable and then use set( ... CACHE ... FORCE) to set the original variable to the same name.

any progress on this? or can it be closed?


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102045/#review4961
-----------------------------------------------------------


On July 22, 2011, 8:34 a.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102045/
> -----------------------------------------------------------
> 
> (Updated July 22, 2011, 8:34 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This fixes a linker error when compiling kdevelop from git on gentoo linux, described here, for example: http://forums.gentoo.org/viewtopic-t-831304-start-0.html
> 
> 
> Diffs
> -----
> 
>   debuggers/gdb/CMakeLists.txt 55aa261 
> 
> Diff: http://git.reviewboard.kde.org/r/102045/diff/
> 
> 
> Testing
> -------
> 
> Well, it compiles.
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120316/29c526de/attachment.html>