Review Request: Make kdev-java compile with the new movingranges interface.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104302/#review11471
-----------------------------------------------------------



CMakeLists.txt
<http://git.reviewboard.kde.org/r/104302/#comment9140>

    this looks odd, are you sure this is required? the line above should suffice



completion/model.cpp
<http://git.reviewboard.kde.org/r/104302/#comment9142>

    remove it



completion/model.cpp
<http://git.reviewboard.kde.org/r/104302/#comment9141>

    remove it instead of commenting it



duchain/declarationbuilder.cpp
<http://git.reviewboard.kde.org/r/104302/#comment9145>

    see above, better port this instead of killing it by commenting it.



duchain/declarationbuilder.cpp
<http://git.reviewboard.kde.org/r/104302/#comment9146>

    see above



duchain/declarationbuilder.cpp
<http://git.reviewboard.kde.org/r/104302/#comment9147>

    see above



parsejob.cpp
<http://git.reviewboard.kde.org/r/104302/#comment9143>

    I'll try to put the PHP editor integrator into KDevplatform as an easy-to-reuse base class. this should be used then. for now you could just copy it from php/duchain/editorintegrator* and adapt the includes.



parsejob.cpp
<http://git.reviewboard.kde.org/r/104302/#comment9144>

    this should be ported instead of commenting it out.
    
    just add the required setters/getters to the java declaration builder.


- Milian Wolff


On March 16, 2012, 12:01 p.m., Detlev Casanova wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104302/
> -----------------------------------------------------------
> 
> (Updated March 16, 2012, 12:01 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Make kdev-java compile with the new movingranges interface.
> Most of the changes are replacing Simple[Range-Cursor] by [Range-Cursor]InRevision
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 93eebfb 
>   completion/context.h afefe08 
>   completion/context.cpp e5b512e 
>   completion/items.cpp 86795d6 
>   completion/model.cpp 3afed23 
>   completion/worker.h 34c6e96 
>   completion/worker.cpp d26c9fc 
>   duchain/classdeclaration.h 4f6faf5 
>   duchain/classdeclaration.cpp 28bfc34 
>   duchain/contextbuilder.h 6f799c5 
>   duchain/contextbuilder.cpp 0d26d43 
>   duchain/declarationbuilder.h 28fcd74 
>   duchain/declarationbuilder.cpp ed263a9 
>   duchain/ducontext.h 3ea0010 
>   duchain/ducontext.cpp 0224199 
>   duchain/dumpchain.cpp f0cf9e4 
>   duchain/editorintegrator.h b2bfd5a 
>   duchain/editorintegrator.cpp 161f9ea 
>   duchain/expressionvisitor.cpp a3e0207 
>   duchain/identifiercompiler.cpp aaad037 
>   duchain/overloadresolver.cpp 26b88fd 
>   duchain/topducontext.h d093186 
>   duchain/topducontext.cpp df88aed 
>   duchain/typebuilder.h ea3817d 
>   duchain/typebuilder.cpp 246cf3b 
>   duchain/typeutils.cpp 42c4eb5 
>   duchain/usebuilder.h 3d141b4 
>   duchain/usebuilder.cpp 244eb95 
>   javalanguagesupport.h b94790e 
>   javalanguagesupport.cpp 49c949b 
>   kdevjavasupport.desktop b9f226a 
>   parsejob.cpp 7c72d61 
>   parser/CMakeLists.txt cc35848 
>   parser/java.g f5b1978 
>   parser/parsesession.h cbb7cba 
>   parser/parsesession.cpp aa466b2 
> 
> Diff: http://git.reviewboard.kde.org/r/104302/diff/
> 
> 
> Testing
> -------
> 
> It does compile (though not with -j5 on my laptop, no idea why)
> It doesn't crash but it doesn't work yet either.
> 
> 
> Thanks,
> 
> Detlev Casanova
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120316/a9d811bf/attachment.html>