Review Request: Exclude Comments in Find/Replace in Files

Andrei G otzy007 at gmail.com
Sun Mar 11 20:44:49 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104230/#review11296
-----------------------------------------------------------

Ship it!


Ship It!

- Andrei G


On March 11, 2012, 8:40 p.m., Andrei G wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104230/
> -----------------------------------------------------------
> 
> (Updated March 11, 2012, 8:40 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> I've add the option for Find/Replace in Files to exclude comments from the results.
> This is my first patch so there could be some issues with it.
> 
> 
> Diffs
> -----
> 
>   plugins/grepview/grepdialog.h d4a1db6 
>   plugins/grepview/grepdialog.cpp b4b8cf5 
>   plugins/grepview/grepjob.h c357b77 
>   plugins/grepview/grepjob.cpp 66df1a9 
>   plugins/grepview/grepwidget.ui 94cfb00 
>   plugins/grepview/tests/findreplacetest.cpp ac0687d 
> 
> Diff: http://git.reviewboard.kde.org/r/104230/diff/
> 
> 
> Testing
> -------
> 
> I've tested on various files(text, .c, .php etc) with/without Exclude Comments option
> 
> 
> Screenshots
> -----------
> 
> Screenshot
>   http://git.reviewboard.kde.org/r/104230/s/460/
> 
> 
> Thanks,
> 
> Andrei G
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120311/2b05484d/attachment.html>


More information about the KDevelop-devel mailing list