Review Request: Add a button to delete sessions in the SessionChooserDialog

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104143/#review11176
-----------------------------------------------------------

Ship it!


Hi!
I think it's something we definitely needed and nobody stepped forward to do. So thanks a lot!

Code-wise, I think it's fine, although I'm not familiar with this code. Anyhow, if it works for you, push it to master and we'll see.

- Aleix Pol Gonzalez


On March 3, 2012, 8:42 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104143/
> -----------------------------------------------------------
> 
> (Updated March 3, 2012, 8:42 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> I've added a very discreet button on the right of the tree view. It is shown after a delay of 500 ms.
> 
> Unfortunately, I had some minor issues with the button's placement. I've managed to fix them manually, and I've added a TODO.
> 
> 
> Diffs
> -----
> 
>   shell/sessioncontroller.cpp 42a2128 
> 
> Diff: http://git.reviewboard.kde.org/r/104143/diff/
> 
> 
> Testing
> -------
> 
> Works for me!
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/104143/s/445/
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120306/40f9065e/attachment.html>