Review Request: Allow bookmarks to be saved and reloaded by using KTextEditor read/writeSessionConfig

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104085/#review11171
-----------------------------------------------------------



shell/textdocument.cpp
<http://git.reviewboard.kde.org/r/104085/#comment9004>

    could this maybe be moved to updateDocEpocEntry?



shell/textdocument.cpp
<http://git.reviewboard.kde.org/r/104085/#comment9001>

    nb -> number



shell/textdocument.cpp
<http://git.reviewboard.kde.org/r/104085/#comment9002>

    nb -> number



shell/textdocument.cpp
<http://git.reviewboard.kde.org/r/104085/#comment9003>

    maybe better make it more robust with a while >= ? of course that means you'll have to get the entryMap in the loop.



shell/textdocument.cpp
<http://git.reviewboard.kde.org/r/104085/#comment9000>

    why did you remove this call here and above?
    
    this is required for properly functioning saving of e.g. folding state, or?


- Milian Wolff


On March 4, 2012, 9:07 p.m., Lambert CLARA wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104085/
> -----------------------------------------------------------
> 
> (Updated March 4, 2012, 9:07 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> As proposed in the bug, use readSessionConfig and writeSessionConfig to allow katepart to remember bookmarks.
> 
> 
> This addresses bug 230862.
>     http://bugs.kde.org/show_bug.cgi?id=230862
> 
> 
> Diffs
> -----
> 
>   shell/textdocument.cpp d595aec 
> 
> Diff: http://git.reviewboard.kde.org/r/104085/diff/
> 
> 
> Testing
> -------
> 
> Open some files, put some bookmarks, close them and reopen them.
> Open some files, put some bookmarks, close kdevelop and relaunch it.
> 
> 
> Thanks,
> 
> Lambert CLARA
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120306/4265c16d/attachment.html>