Review Request: Make C macro variadic argument optional

Alexandre Courbot gnurou at gmail.com
Wed Jun 20 13:51:18 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105307/
-----------------------------------------------------------

Review request for KDevelop.


Summary (updated)
-----------------

Make C macro variadic argument optional


Description (updated)
-------

In GNU C, the variadic argument of a macro can be completely left out
without triggering an error (as explained in
http://gcc.gnu.org/onlinedocs/cpp/Variadic-Macros.html)


Diffs (updated)
-----

  languages/cpp/parser/rpp/pp-engine.cpp ca566cb 
  languages/cpp/parser/tests/test_parser.cpp 804f379 

Diff: http://git.reviewboard.kde.org/r/105307/diff/


Testing (updated)
-------

Checked that the faulty case was not triggering a parsing error anymore. Checked that no regression was introduced in the testPreprocessor() test case.


Thanks,

Alexandre Courbot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120620/6124ae85/attachment.html>


More information about the KDevelop-devel mailing list