Review Request: add support for Okteta 0.9
Milian Wolff
mail at milianw.de
Mon Jun 18 12:29:33 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105211/#review14827
-----------------------------------------------------------
Ship it!
quite ugly I have to say but well, go for it.
- Milian Wolff
On June 11, 2012, 2:55 p.m., Friedrich W. H. Kossebau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105211/
> -----------------------------------------------------------
>
> (Updated June 11, 2012, 2:55 p.m.)
>
>
> Review request for KDevelop.
>
>
> Description
> -------
>
> Of course the upcoming Okteta 0.9 again has a different API, so the Okteta plugin will not be build with it. Unless this patch is committed :)
>
> Needs at least kdesdk from svn commit 1299667. The SC 4.9 beta2 tarballs have been rerolled to be based on 1299778, so min. released kdesdk/okteta packages are the beta2 ones.
>
> Backport to 4.3 currently blocked by the messed 4.3 branch, but might be a simple cherry-pick. Okay to also backport and commit, once the 4.3 branch is cleared again? Backport with or without the one string addition?
>
>
> Diffs
> -----
>
> cmake/modules/FindLibKasten.cmake 087eedc
> cmake/modules/FindLibOktetaKasten.cmake 973f0f1
> utils/CMakeLists.txt 1545d8c
> utils/okteta/kastentoolviewwidget.cpp b10974e
> utils/okteta/kdevokteta.rc e5314cf
> utils/okteta/oktetadocument.h 56eba46
> utils/okteta/oktetadocument.cpp abb047d
> utils/okteta/oktetaglobal.h 0113bbb
> utils/okteta/oktetaplugin.h 3eec9f7
> utils/okteta/oktetaplugin.cpp c8a7fd4
> utils/okteta/oktetatoolviewfactory.cpp ed0cf13
> utils/okteta/oktetaview.h 29a6b39
> utils/okteta/oktetaview.cpp 249aaaa
> utils/okteta/oktetawidget.h dfc9907
> utils/okteta/oktetawidget.cpp 0fac371
>
> Diff: http://git.reviewboard.kde.org/r/105211/diff/
>
>
> Testing
> -------
>
> Opened a few files as byte arrays, edited and changed view profiles.
>
>
> Thanks,
>
> Friedrich W. H. Kossebau
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120618/7fed3925/attachment.html>
More information about the KDevelop-devel
mailing list