Review Request: Move additional status gathering to VCSDiffPatchSource from VCSCommitDiffPatchSource

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105797/#review16648
-----------------------------------------------------------

Ship it!


Looks good, but don't commit it to 4.4.

- Aleix Pol Gonzalez


On July 30, 2012, 2:52 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105797/
> -----------------------------------------------------------
> 
> (Updated July 30, 2012, 2:52 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Just as in summary: make not only VCSCommitDiffPatchSource, but also VCSDiffPatchSource invoke VCS's status job to get additional information on files.
> 
> This allows to see files' extended statuses (added/deleted/conflicted) not only when committing, but also when invoking "Show differences..." from the context menu.
> 
> 
> Diffs
> -----
> 
>   vcs/widgets/vcsdiffpatchsources.h 12b948d 
>   vcs/widgets/vcsdiffpatchsources.cpp 059e3e2 
> 
> Diff: http://git.reviewboard.kde.org/r/105797/diff/
> 
> 
> Testing
> -------
> 
> Existing unit-tests + manual testing (Git, CVS backends).
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120730/66a88046/attachment.html>