Review Request: Add "-N" to arguments for CVS diff job

Ivan Shapovalov intelfx100 at gmail.com
Mon Jul 30 14:45:31 UTC 2012



> On July 30, 2012, 2:40 p.m., Aleix Pol Gonzalez wrote:
> > If it works for you, I think it's fine, there's not so much people using the cvs plugin, I think.
> > 
> > I hereby propose you as maintainer for the CVS plugin, you should be able to do and undo by yourself if you're interested.

I don't use CVS.. That's being done by request of some another user (daviddoria on IRC).


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105794/#review16646
-----------------------------------------------------------


On July 30, 2012, 2:32 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105794/
> -----------------------------------------------------------
> 
> (Updated July 30, 2012, 2:32 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Unconditionally call "cvs diff -Nu" instead of "cvs diff -u".
> The "-N" switch stands for "include newly added files in the diff". (It apparently has no effect when diff is invoked between revisions, so it's safe to include it always.)
> 
> Note: "newly added" corresponds here to Git's "newly added to the index", so it is good to see them in diff output.
> 
> 
> Diffs
> -----
> 
>   plugins/cvs/cvsplugin.cpp 984f38b 
> 
> Diff: http://git.reviewboard.kde.org/r/105794/diff/
> 
> 
> Testing
> -------
> 
> Existing unit-tests + manual testing.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120730/24f6696d/attachment.html>


More information about the KDevelop-devel mailing list