Review Request: In DVcsJob, distinguish "process crashed" from "process exited with non-zero" when calling error handling function

Aleix Pol Gonzalez aleixpol at gmail.com
Mon Jul 30 14:37:23 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105793/#review16645
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On July 30, 2012, 2:27 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105793/
> -----------------------------------------------------------
> 
> (Updated July 30, 2012, 2:27 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Call slotProcessError() with different parameters depending on whether the process had crashed or had just exited with non-zero code.
> 
> 
> Diffs
> -----
> 
>   vcs/dvcs/dvcsjob.cpp 1e0f187 
> 
> Diff: http://git.reviewboard.kde.org/r/105793/diff/
> 
> 
> Testing
> -------
> 
> Existing unit-tests + manual testing.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120730/942c8881/attachment.html>


More information about the KDevelop-devel mailing list