Review Request: Add "-N" to arguments for CVS diff job

Ivan Shapovalov intelfx100 at gmail.com
Mon Jul 30 14:32:08 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105794/
-----------------------------------------------------------

Review request for KDevelop.


Description
-------

Unconditionally call "cvs diff -Nu" instead of "cvs diff -u".
The "-N" switch stands for "include newly added files in the diff". (It apparently has no effect when diff is invoked between revisions, so it's safe to include it always.)

Note: "newly added" corresponds here to Git's "newly added to the index", so it is good to see them in diff output.


Diffs
-----

  plugins/cvs/cvsplugin.cpp 984f38b 

Diff: http://git.reviewboard.kde.org/r/105794/diff/


Testing
-------

Existing unit-tests + manual testing.


Thanks,

Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120730/6de71d78/attachment.html>


More information about the KDevelop-devel mailing list