Review Request: [KDE Provider] Include Modules in the Project List

[David Narváez]

> On July 27, 2012, 2:36 p.m., Andreas Pakulat wrote:
> > providers/kdeprovider/kdeprojectsmodel.h, line 33
> > <http://git.reviewboard.kde.org/r/105752/diff/1/?file=74955#file74955line33>
> >
> >     why not call this module or modulename? After all thats what it means as far as I understood from the xml parser, right?
> 
> David Narváez wrote:
>     Not really. I agree "type" is not the best name for that attribute but what it stores is whether the item is a project or a module - the project or module name is stored in the name attribute. The only purpose of that is the Q_ASSERT a couple of lines below just to make sure we always close a module with a </module> tag and a project with a </project> tag. Still, any other suggestions for a name are welcome.
> 
> Andreas Pakulat wrote:
>     Ah, misread part of the patch. If the member says wether its a Project or Module, it should IMO be a flag with a corresponding Enum.

Yes, I thought so too, but then my patch would be like 6 lines longer in order to if-else-if the name string and set the right value of the enum and... yes, I'm lazy :P

I'll update the patch with a proper enum.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105752/#review16528
-----------------------------------------------------------


On July 27, 2012, 12:35 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105752/
> -----------------------------------------------------------
> 
> (Updated July 27, 2012, 12:35 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Include elements named module which also have icons, urls with protocols and all. Modules include KDE PIM and KDE Multimedia, among others.
> 
> 
> Diffs
> -----
> 
>   providers/kdeprovider/kdeprojectsmodel.h 25dd739 
>   providers/kdeprovider/kdeprojectsmodel.cpp 56498da 
>   providers/kdeprovider/kdeprojectsreader.cpp 536c2eb 
> 
> Diff: http://git.reviewboard.kde.org/r/105752/diff/
> 
> 
> Testing
> -------
> 
> 1. Open the KDE Provider
> 2. Filter the project list by PIM
> 
> Before this patch, no PIM module would be loaded. After this patch, all three PIM modules are available for download.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120727/f407b677/attachment.html>