Review Request: [KDE Provider] Include Modules in the Project List

[David Narváez]

> On July 27, 2012, 7:13 p.m., Aleix Pol Gonzalez wrote:
> > providers/kdeprovider/kdeprojectsreader.cpp, line 78
> > <http://git.reviewboard.kde.org/r/105752/diff/1/?file=74957#file74957line78>
> >
> >     Shouldn't the type be the identifier attribute's value?

No, same answer as above.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105752/#review16543
-----------------------------------------------------------


On July 27, 2012, 12:35 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105752/
> -----------------------------------------------------------
> 
> (Updated July 27, 2012, 12:35 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Include elements named module which also have icons, urls with protocols and all. Modules include KDE PIM and KDE Multimedia, among others.
> 
> 
> Diffs
> -----
> 
>   providers/kdeprovider/kdeprojectsmodel.h 25dd739 
>   providers/kdeprovider/kdeprojectsmodel.cpp 56498da 
>   providers/kdeprovider/kdeprojectsreader.cpp 536c2eb 
> 
> Diff: http://git.reviewboard.kde.org/r/105752/diff/
> 
> 
> Testing
> -------
> 
> 1. Open the KDE Provider
> 2. Filter the project list by PIM
> 
> Before this patch, no PIM module would be loaded. After this patch, all three PIM modules are available for download.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120727/670b135a/attachment.html>