Request for Review: Move kdev-custom-buildsystem into kdevelop

[Andreas Pakulat]

Hi,

On Wed, Jul 25, 2012 at 7:31 PM, Aleix Pol <aleixpol at kde.org> wrote:
> On Sat, Jul 21, 2012 at 7:45 PM, Andreas Pakulat <apaku at gmx.de> wrote:
>> Hi,
>>
>> the custom buildsystem plugin for KDevelop/KDevPlatform has been
>> started off as a separate project since I didn't want to be tied to
>> the kdevelop schedule for releases. Unfortunately my lack of time make
>> it cumbersome to follow up on API changes in the plugin myself and it
>> seems like having it separate also hinders its packaging and wider
>> usage.
>>
>> Hence I plan to move the plugin into kdevelop in two weeks from now.
>> I'd welcome any feedback on the current codebase. The project site is
>> at https://projects.kde.org/projects/extragear/kdevelop/plugins/kdev-custom-buildsystem.
>>
>> Andreas
>>
>>>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
>
> Just took a quick look on it and it looks fine. Also given that we've
> had users of this plugin for some time already, I don't think it
> should be a problem for it to be part of the KDevelop codebase.
>
> It's a good think that it is unit tested too. :)

Uhm, well, if you look at the tests they're not all that great. In
fact most of the actual code is dealing with ui-stuff which is hard to
unit-test. So the coverage is anything bug great, but I guess its a
start.

Andreas