Review Request: Correctly set completion properties for enumerators
Olivier Jean de Gaalon
olivier.jg at gmail.com
Thu Jul 19 12:22:43 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105616/#review16112
-----------------------------------------------------------
Ship it!
Sounds like progress to me.
- Olivier Jean de Gaalon
On July 19, 2012, 7:42 a.m., Ivan Shapovalov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105616/
> -----------------------------------------------------------
>
> (Updated July 19, 2012, 7:42 a.m.)
>
>
> Review request for KDevelop.
>
>
> Description
> -------
>
> EnumeratorType is rather a variable (compile-time integral constant) than an enum type-name, so mark it accordingly.
> QUESTION: although this is valid for C/C++, are there any places where an EnumeratorType would represent something different?
>
> // this alone won't fix any bugs, there is a dependent change in queue
>
>
> Diffs
> -----
>
> language/duchain/duchainutils.cpp 1879540
>
> Diff: http://git.reviewboard.kde.org/r/105616/diff/
>
>
> Testing
> -------
>
> Existing unit-tests pass.
>
>
> Thanks,
>
> Ivan Shapovalov
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120719/6a715e03/attachment.html>
More information about the KDevelop-devel
mailing list