Review Request: Prevent code navigation tooltip hiding when moving mouse over the identifier.

Milian Wolff mail at milianw.de
Mon Jul 16 20:22:32 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105403/#review15983
-----------------------------------------------------------



language/duchain/duchainutils.cpp
<http://git.reviewboard.kde.org/r/105403/#comment12585>

    this looks wrong, please reuse the declarationUnderCursor function available in the same file and just return it's range.
    
    if that fails, please look at the context browser plugin, it should have some code to find that range and reuse that code (by pushing it here).



plugins/contextbrowser/contextbrowser.cpp
<http://git.reviewboard.kde.org/r/105403/#comment12586>

    patches for ktexteditor would be welcome, and: what happens for 1-line documents (does it just fail or is it crashing or so?)
    
    if it just fails, this is OK for me as these docs should occur fairly rarely


- Milian Wolff


On July 1, 2012, 5:27 p.m., Maciej Cencora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105403/
> -----------------------------------------------------------
> 
> (Updated July 1, 2012, 5:27 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This works by looking up the item's Range in DUChain and adding its geometry boundaries as extra rectangle to tooltop.
> 
> If there's another way to get line height (in pixels) in kate I'd be more than happy to use it instead of the hack I wrote.
> 
> 
> Diffs
> -----
> 
>   language/duchain/duchainutils.h d3cc1af 
>   language/duchain/duchainutils.cpp 1879540 
>   plugins/contextbrowser/contextbrowser.cpp 4056ac0 
> 
> Diff: http://git.reviewboard.kde.org/r/105403/diff/
> 
> 
> Testing
> -------
> 
> Manual testing performed
> 
> 
> Thanks,
> 
> Maciej Cencora
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120716/9444b1d1/attachment.html>


More information about the KDevelop-devel mailing list