Review Request: Rework layout of the "Configure Launch" dialog

[Aurélien Gâteau]

> On July 10, 2012, 3:03 p.m., Aleix Pol Gonzalez wrote:
> > In general I like it.
> > I wonder what it will look like with many big projects, but I guess we can sort it out through the menu.
> > 
> > I'd suggest to push it for kdevelop 4.5, this way we'll have time to figure out if it's what we need.

Not sure when kdevelop 4.5 is going to happen so I pushed the branch as agateau/launchdialog-redesign for now. Can I merged it in kdevplatform master or should I wait?


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105505/#review15621
-----------------------------------------------------------


On July 10, 2012, 2:50 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105505/
> -----------------------------------------------------------
> 
> (Updated July 10, 2012, 2:50 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Following the KDevelop BoF, I worked a bit on the "configure launch" dialog.
> 
> Changes are:
> - Remove multiple margins
> - Reworked layout: getting rid of some labels, adding labels to buttons
> - Simplify "Add" button menu when possible: if the first and second levels are only made of one item, directly show the third level. If only the first level is one-item, show the second and third level.
> 
> This patch could have been broken in multiple parts (they are individual commits in my work branch), but I was a bit too lazy to file them separately :/
> 
> Further possible improvements:
> - the "Add" button could be simplified a bit more by always showing the menu, but I may be missing a case where adding an empty launch is useful.
> - the "launch" name is currently editable through the tree view only, I think it should rather be a field in the detail part.
> - the way to pick the executable could be simplified by only showing the target combobox by default. The combobox would have an additional "custom" entry, which when selected would show a lineedit to let the user enter the executable name.
> 
> 
> Diffs
> -----
> 
>   plugins/execute/nativeappconfig.ui 3496edd 
>   shell/launchconfigurationdialog.cpp 372510a 
>   shell/launchconfigurationdialog.ui d287077 
> 
> Diff: http://git.reviewboard.kde.org/r/105505/diff/
> 
> 
> Testing
> -------
> 
> Tested with one project and multiple projects in one session.
> 
> 
> Screenshots
> -----------
> 
> Relayout
>   http://git.reviewboard.kde.org/r/105505/s/619/
> Simplified "add" menu
>   http://git.reviewboard.kde.org/r/105505/s/620/
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120713/bec6ef26/attachment.html>