Review Request: Get CMake cache representation to properly update after re-configuring.

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105436/#review15670
-----------------------------------------------------------


This review has been submitted with commit e5ecb19009066bdb15154428089c80732e1de423 by Ivan Shapovalov to branch master.

- Commit Hook


On July 11, 2012, 4:54 a.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105436/
> -----------------------------------------------------------
> 
> (Updated July 11, 2012, 4:54 a.m.)
> 
> 
> Review request for KDevelop and Aleix Pol Gonzalez.
> 
> 
> Description
> -------
> 
> The cache is now updated after configuration is completed (by signal from the job).
> 
> This 1) allows to see configuration results when a new build directory is created,
> and 2) fixes cache view appearance (4 unnamed columns) after repeated re-configuring.
> 
> Also, CMakePreferences::buildDirChanged() has been changed to receive an index instead of a string.
> This will come in handy if at some point multiple build directory configurations sharing the same path will be allowed (for example, with different CMake binary pathes): a couple of days ago there was a request for such functionality on kdevelop's IRC channel.
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/settings/cmakepreferences.h 4195948 
>   projectmanagers/cmake/settings/cmakepreferences.cpp 5be668b 
> 
> Diff: http://git.reviewboard.kde.org/r/105436/diff/
> 
> 
> Testing
> -------
> 
> Manual testing, works as expected now.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120711/08fb491f/attachment.html>