Review Request: Proper auto-completion in switch statements

Ivan Shapovalov intelfx100 at
Sun Jul 8 05:31:52 UTC 2012

This is an automatically generated e-mail. To reply, visit:

(Updated July 8, 2012, 5:31 a.m.)

Review request for KDevelop.


removed CodeCompletionContext::requiredPrefix() - updated diffs


Improve code completion within switch statements.

1) Resolve type of the switch'd expression correctly
 - in switchExpressionType(), replaced evaluateType() with evaluateExpression()

2) Add completion items for enumerations declared in different scopes
 - this required adding another condition branch in the end of CodeCompletionContext::standardAccessCompletionItems(),
which in turn required proper setting of m_expressionResult in CaseAccess contexts,
which required moving switchExpressionType() to CodeCompletionContext::caseAccessCompletionItems() and re-ordering some code.

Diffs (updated)

  languages/cpp/codecompletion/context.h a5fdea7 
  languages/cpp/codecompletion/context.cpp 33dcad1 
  languages/cpp/codecompletion/item.h 4735f2a 
  languages/cpp/codecompletion/item.cpp affd4e6 
  languages/cpp/tests/test_cppcodecompletion.h 20a70cb 
  languages/cpp/tests/test_cppcodecompletion.cpp ec82d2d 



There are unit-tests, but they do not work since DUChainBase::createRangeMoving(), which is used to parse switch'd expression type, does not work without an editor.


Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list