Review Request: KDevelop: Use outputview/outputmodel

Morten Volden mvolden2 at gmail.com
Sat Jul 7 11:13:58 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105321/
-----------------------------------------------------------

(Updated July 7, 2012, 11:13 a.m.)


Review request for KDevelop.


Changes
-------

Anyone?


Description
-------

This patch is related to: http://git.reviewboard.kde.org/r/104814/
(Share code between makebuilder and external scripts). It uses the outputmodel defined in outputview/outputmodel and removes makeoutputmodel.


Diffs (updated)
-----

  projectbuilders/makebuilder/CMakeLists.txt 1674533 
  projectbuilders/makebuilder/makebuilder.h 131324d 
  projectbuilders/makebuilder/makebuilder.cpp b504a22 
  projectbuilders/makebuilder/makejob.h 2cb7ef9 
  projectbuilders/makebuilder/makejob.cpp 147dbfb 
  projectbuilders/makebuilder/makeoutputdelegate.h a33a4ca 
  projectbuilders/makebuilder/makeoutputdelegate.cpp 688ec3c 
  projectbuilders/makebuilder/makeoutputmodel.h a088267 
  projectbuilders/makebuilder/makeoutputmodel.cpp d2fdfb4 
  projectbuilders/makebuilder/outputfilters.h 0b8b9d0 
  projectbuilders/makebuilder/outputfilters.cpp 1017de0 
  projectbuilders/makebuilder/tests/CMakeLists.txt bb16aca 
  projectbuilders/makebuilder/tests/test_makeoutputmodel.h 0f5c8ce 
  projectbuilders/makebuilder/tests/test_makeoutputmodel.cpp 5955c6b 

Diff: http://git.reviewboard.kde.org/r/105321/diff/


Testing
-------

Ported the tests from makeoutputmodel to outputview/outputmodel and outputview/filteringstrategies


Thanks,

Morten Volden

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120707/f9e24529/attachment.html>


More information about the KDevelop-devel mailing list