Review Request: Store CMake build system settings per build directory rather than globally (TODO in cmakepreferences.cpp)

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105308/#review15426
-----------------------------------------------------------

Ship it!


Ok, let's get it in, seems stable.

- Aleix Pol Gonzalez


On July 3, 2012, 9:40 a.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105308/
> -----------------------------------------------------------
> 
> (Updated July 3, 2012, 9:40 a.m.)
> 
> 
> Review request for KDevelop and Aleix Pol Gonzalez.
> 
> 
> Description
> -------
> 
> This addresses the TODO at the beginning of cmakepreferences.cpp, making
> CMake build system settings saved in the project configuration file
> separately for each configured build directory.
> This is now done by using sub-groups per each configured build directory (as suggested by Andreas).
> Specifically, 5 places have been changed:
> * cmakeconfig.kcfg: dropped.
> * cmakeutils.{h,cpp}: functions changed to use multiple groups.
> * cmakepreferences.{h,cpp}: functions changed to use primitives from cmakeutils.{h,cpp} + commented out
> the save() call on build directory creation since it is somewhat annoying.
> * cmakejob.cpp: cmakeArguments() had been changed to make it use
> temporary variables instead of calling each fetch function twice.
> * cmakemanager.cpp: on project load there is attempt to migrate the configuration file to new format.
> 
> URLs are saved to via KUrl::url().
> 
> 
> Diffs
> -----
> 
>   projectbuilders/cmakebuilder/cmakejob.cpp af05577 
>   projectmanagers/cmake/CMakeLists.txt dc013f4 
>   projectmanagers/cmake/cmakeconfig.kcfg 5ca623e 
>   projectmanagers/cmake/cmakeconfig.kcfgc d580702 
>   projectmanagers/cmake/cmakemanager.cpp ad496e7 
>   projectmanagers/cmake/cmakeutils.h 5586d4d 
>   projectmanagers/cmake/cmakeutils.cpp 3c9b736 
>   projectmanagers/cmake/settings/cmakebuildsettings.ui d025adf 
>   projectmanagers/cmake/settings/cmakepreferences.h 4195948 
>   projectmanagers/cmake/settings/cmakepreferences.cpp 5be668b 
> 
> Diff: http://git.reviewboard.kde.org/r/105308/diff/
> 
> 
> Testing
> -------
> 
> Used two build directories on a project, one configured to build with MinGW via -DCMAKE_TOOLCHAIN_FILE.
> Ensured the settings are saved and applied correctly across build directory switch and KDevelop multiple restart.
> Existing projects' configurations are picked up correctly.
> 
> All unit-tests are also passed.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120705/2fab64b6/attachment.html>