Review Request: Proper auto-completion in switch statements

[Ivan Shapovalov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105410/
-----------------------------------------------------------

(Updated July 5, 2012, 1:29 p.m.)


Review request for KDevelop.


Changes
-------

Fixed various issues pointed out by Olivier Jean de Gaalon.


Description
-------

Improve code completion within switch statements.

1) Resolve type of the switch'd expression correctly
 - in switchExpressionType(), replaced evaluateType() with evaluateExpression()

2) Correctly complete code for enumerations (e. g. do not mark type declarations as matching items)
 - this required adding integral constant check in CodeCompletionContext::standardAccessCompletionItems()

3) Add completion items for enumerations declared in different scopes
 - this required adding another condition branch in the end of CodeCompletionContext::standardAccessCompletionItems(),
which in turn required proper setting of m_expressionResult in CaseAccess contexts,
which required moving switchExpressionType() to doCaseCompletion() to avoid code duplication.


Diffs (updated)
-----

  languages/cpp/codecompletion/context.h a5fdea7 
  languages/cpp/codecompletion/context.cpp 33dcad1 
  languages/cpp/codecompletion/item.cpp affd4e6 
  languages/cpp/tests/test_cppcodecompletion.h 20a70cb 
  languages/cpp/tests/test_cppcodecompletion.cpp ec82d2d 

Diff: http://git.reviewboard.kde.org/r/105410/diff/


Testing
-------

there is a unit-test for change (1),
I don't know how to test (2) and
(3) cannot be tested due to some weird things with CompletionItemTester though it can be tested manually.


Thanks,

Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120705/cd247605/attachment.html>