Review Request: Save/Restore the ProjectTreeView. This enables a more seamless transition when returning to a project that was closed.

[Andrew Fuller]

> On Jan. 5, 2012, 11:51 a.m., Andreas Pakulat wrote:
> > Current master requires KDE 4.6 already I believe (if not it should due to the huge amount of fixes related to kate).
> > 
> > I didn't look at the patch itself yet, but how does your code handle the case of two project views being restored? As far as I recall there's no API for plugins/views to find out which kconfig group to use to restore view-state from since this is completely hidden in sublime/shell code.
> > 
> > Apart from that IMHO storing this in the project configuration is wrong. The view state has nothing to do with the project itself, its about view-state and view-state should go into the session configuration file. The project-configuration file is for project-specific data, which expansion state is not, since I can load the same project into two different sessions and would not want one session to overwrite the view-state of another session for that project.
> 
> Andrew Fuller wrote:
>     CMakeLists still has set(KDE_MIN_VERSION "4.5.0")  I can bump that if you like, but that doesn't belong in this patch considering the remove of the #if/#else (below).
>     
>     Re: multiple project views.  Until now I was not aware that this was even possible.  I will address that in my updated patch (which will be hopefully tomorrow).
> 
> Andreas Pakulat wrote:
>     I'd say it should be bumped, but I'm not active anymore so I'll leave that to the active group of devs.
>     
>     As I said, I don't think you'll be able to adress multiple project views currently since a view-object does not know which config group to read the state from. This has been a long-time todo for the sublime/shell API but didn't get done yet (again afaik, I'm a bit out of touch these days).
>     
>     Anyway, if Milian is ok with that it might still be useful enough to warrant this minor issue, after all there are not going to be many people with more than 1 projects view. There's IIRC also a plan to have some views as 'singleton', i.e. only a single instance of the view is ever created and the project tree is a prime candidate for that IMHO.

I tried adding a second project view in a session, but when I exited and re-opened the session I was presented with a single project view.  The upside of this behaviour is that saving/restoring the state of the project view need not concern itself with multiple views!


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103619/#review9567
-----------------------------------------------------------


On Jan. 7, 2012, 2:45 a.m., Andrew Fuller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103619/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2012, 2:45 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Save/Restore the ProjectTreeView.  This enables a more seamless transition when returning to a project that was closed.
> 
> 
> Diffs
> -----
> 
>   plugins/projectmanagerview/CMakeLists.txt 7b58e8e5489819b0370f5d55e0218f063da90af2 
>   plugins/projectmanagerview/projecttreeview.h 16893f0713b83a78a5b025a55fcfa082265d4419 
>   plugins/projectmanagerview/projecttreeview.cpp 8237af513627c0459d571de2bccc275e8a4b0ae9 
>   project/CMakeLists.txt bac4b22b8a9966f4efe4080a6d24e0de17c48e12 
>   project/projectmodelsaver.h PRE-CREATION 
>   project/projectmodelsaver.cpp PRE-CREATION 
>   shell/sessioncontroller.h 551894d4131218b9ab2640e28f2c354ce319a105 
>   shell/sessioncontroller.cpp d2ee8732710e0e4bded56e547d83a3906b20b018 
> 
> Diff: http://git.reviewboard.kde.org/r/103619/diff/diff
> 
> 
> Testing
> -------
> 
> Load a session, Exit, and return.  Voilà!  The tree is right where you left it.
> 
> 
> Thanks,
> 
> Andrew Fuller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120107/dac65504/attachment.html>