Review Request: Offer create private/protected members when possible in missingdeclarationaction

[Jonas Jacobi]

> On Jan. 2, 2012, 3:57 p.m., Jonas Jacobi wrote:
> > ping
> 
> Milian Wolff wrote:
>     it is not in the proper "git format-diff" format, i.e. missing the commit message and your authoring details.
>     
>     please re-do this, and double check. Just open the created patch, it should look like a raw email.
>     
>     bye

It was created in the correct format but somehow got changed when i uploaded with update diff (or does that only show the diff anyway?).
i added the correct version as a file attachment.
I also tried to update the diff again, but this lead to reviewboard showing a completely wrong version which has nothing to do with the file i uploaded, but seems to be an older version of the diff oO.


- Jonas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102625/#review9454
-----------------------------------------------------------


On Jan. 5, 2012, 10:13 a.m., Jonas Jacobi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102625/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2012, 10:13 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Currently only public member variables can be declared in some contexts.
> This patch checks whether private/protected members would be also accessible from the current context (disregarding friend declarations atm)
> and if so, offer the possibility to create the members.
> e.g.
> 
> class A {
> public:
>   A(int x) : mUndeclared(x) {} // <- declare mUndeclared as private/protected/public member
> };
> 
> class B : public A {
> public:
>   void foo() {
>     A a(2);
>     a.undeclared = 5; // <- declare undeclared as protected/public
>   }
> };
> 
> class X {
> public:
>   void bar() {
>     B b;
>     b.undeclared = 5; // <- declare undeclared as public
>   }
> };
> 
> 
> Diffs
> -----
> 
>   languages/cpp/cppduchain/missingdeclarationassistant.cpp bafc159 
> 
> Diff: http://git.reviewboard.kde.org/r/102625/diff/diff
> 
> 
> Testing
> -------
> 
> I'm currently using it
> 
> 
> Thanks,
> 
> Jonas Jacobi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120105/c37ec061/attachment.html>