Review Request: Allow bookmarks to be saved and reloaded by using KTextEditor read/writeSessionConfig
Lambert CLARA
lambert.clara at yahoo.fr
Wed Feb 29 19:43:29 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104085/
-----------------------------------------------------------
(Updated Feb. 29, 2012, 7:43 p.m.)
Review request for KDevelop.
Changes
-------
- Use ParameterizedSessionConfigInterface to be sure that no more stuff than bookmarks gets saved/reloaded
- Save the bookmarks when markChanged signal is emitted instead of at the document close
- Inline the access to configGroup upon Milian request
- Move the load and save code into methods
- Move the include sessionconfiginterface.h header with the other ktexteditor includes
Description
-------
As proposed in the bug, use readSessionConfig and writeSessionConfig to allow katepart to remember bookmarks.
This addresses bug 230862.
http://bugs.kde.org/show_bug.cgi?id=230862
Diffs (updated)
-----
shell/textdocument.h 5dcd0a9
shell/textdocument.cpp 4d9ace7
Diff: http://git.reviewboard.kde.org/r/104085/diff/
Testing
-------
Open some files, put some bookmarks, close them and reopen them.
Open some files, put some bookmarks, close kdevelop and relaunch it.
Thanks,
Lambert CLARA
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120229/b4cceccb/attachment.html>
More information about the KDevelop-devel
mailing list