Review Request: Custom build system: Make multipath unittest pass

[Morten Volden]

> On Dec. 23, 2011, 10:27 p.m., Andreas Pakulat wrote:
> > Hmm, I wonder wether it might be better to compare the actual url's instead of their string-representation. Or does the test still fail when removing the .url from both sides?
> 
> Milian Wolff wrote:
>     you should use url.equals() with KUrl::CompareWithoutTrailingSlash
> 
> Andreas Pakulat wrote:
>     That would require a QCOMPARE macro that understands KUrl, which I don't think exists and is not worth doing for this single case IMHO. Using QVERIFY is almost always not nice since it requires manually assembling a message.

What should we do? Ship it, or change?


- Morten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103523/#review9223
-----------------------------------------------------------


On Dec. 23, 2011, 10:12 p.m., Morten Volden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103523/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2011, 10:12 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Make multipath unittest pass
> 
> 
> Diffs
> -----
> 
>   tests/custombuildsystemplugintest.cpp ab2c861 
> 
> Diff: http://git.reviewboard.kde.org/r/103523/diff/
> 
> 
> Testing
> -------
> 
> The test now passes
> 
> 
> Thanks,
> 
> Morten Volden
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120228/3b5f5ec1/attachment.html>