Review Request: Improve QuickOpen system to sort items based on typed text

Milian Wolff mail at milianw.de
Tue Feb 28 14:39:49 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103955/#review10986
-----------------------------------------------------------

Ship it!


looks good, could you please send me the patch as created by "git format-patch"?

thanks


plugins/quickopen/projectitemquickopen.cpp
<http://git.reviewboard.kde.org/r/103955/#comment8908>

    wrong name here (distanceToComma)


- Milian Wolff


On Feb. 12, 2012, 5:57 p.m., Victor Vicente Carvalho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103955/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2012, 5:57 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Improve QuickOpen system to sort items based on a right-to-left approach, putting items that are close to the typed text next to the first matches. This is achieved through a weighted sorter on the ProjectItemDataProvider filter.
> 
> 
> Diffs
> -----
> 
>   plugins/quickopen/projectitemquickopen.cpp 1caadffee64051a0d77d7a65a97ff86b33a78d39 
> 
> Diff: http://git.reviewboard.kde.org/r/103955/diff/
> 
> 
> Testing
> -------
> 
> Ran kdevelop over several projects, no problems so far.
> 
> 
> Thanks,
> 
> Victor Vicente Carvalho
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120228/ceabb9fc/attachment.html>


More information about the KDevelop-devel mailing list