Review Request: Allow bookmarks to be saved and reloaded by using KTextEditor read/writeSessionConfig

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104085/#review10926
-----------------------------------------------------------



shell/textdocument.cpp
<http://git.reviewboard.kde.org/r/104085/#comment8881>

    move this into a inline function and reuse that in the both cases (i.e. read & write calls). Also rename the variable from pInterface to something better, like sessionIface or similar (esp. the p-prefix is not used in kdevelop code).
    
    if (sessionIface = ...) {
      sessionIface->writeSessionConfig(sessionConfig(d->document));
    }


- Milian Wolff


On Feb. 26, 2012, 8:43 p.m., Lambert CLARA wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104085/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2012, 8:43 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> As proposed in the bug, use readSessionConfig and writeSessionConfig to allow katepart to remember bookmarks.
> 
> 
> This addresses bug 230862.
>     http://bugs.kde.org/show_bug.cgi?id=230862
> 
> 
> Diffs
> -----
> 
>   shell/textdocument.cpp 6939ea6 
> 
> Diff: http://git.reviewboard.kde.org/r/104085/diff/
> 
> 
> Testing
> -------
> 
> Open some files, put some bookmarks, close them and reopen them.
> Open some files, put some bookmarks, close kdevelop and relaunch it.
> 
> 
> Thanks,
> 
> Lambert CLARA
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120226/ff2835be/attachment.html>