[kdevplatform/1.3] sublime: Disable the multiple-toolview support for the 4.3 release

David nolden david.nolden.kde at art-master.de
Wed Feb 15 12:03:43 UTC 2012


Git commit afefe3f012985bc27e35a9217abda23623d452ed by David nolden.
Committed on 14/02/2012 at 21:03.
Pushed by zwabel into branch '1.3'.

Disable the multiple-toolview support for the 4.3 release

Reason: Inherent bugs which need significant work to be fixed.
Example: Open two equal toolviews (for example 2x konsole),
activate one, switch area, switch back, -> Both are
active instead of one. The problem is that views are
identified purely by their factory-id, which is equal
for toolviews of the same type.
The resulting state with 2 open toolviews looks buggy
and is unexpected and difficult to fix for the user,
this shouldn't happen in a quality release.

CCMAIL: kdevelop-devel at barney.cs.uni-potsdam.de

M  +9    -0    sublime/ideal.cpp

http://commits.kde.org/kdevplatform/afefe3f012985bc27e35a9217abda23623d452ed

diff --git a/sublime/ideal.cpp b/sublime/ideal.cpp
index d4fa43d..afb3976 100644
--- a/sublime/ideal.cpp
+++ b/sublime/ideal.cpp
@@ -741,6 +741,15 @@ void IdealController::slotDockBarContextMenuRequested(QPoint position)
 
 void IdealController::raiseView(View* view, RaiseMode mode)
 {
+    /// @todo GroupWithOtherViews is disabled for now by forcing "mode = HideOtherViews".
+    ///       for the release of KDevelop 4.3.
+    ///       Reason: Inherent bugs which need significant changes to be fixed.
+    ///       Example: Open two equal toolviews (for example 2x konsole),
+    ///                activate one, switch area, switch back, -> Both are active instead of one.
+    ///       The problem is that views are identified purely by their factory-id, which is equal
+    ///       for toolviews of the same type.
+    mode = HideOtherViews;
+   
     QAction* action = m_view_to_action.value(view);
     Q_ASSERT(action);
 





More information about the KDevelop-devel mailing list