Review Request: Fix same file opened multiple times when using split views and buddies

[Milian Wolff]

> On Feb. 14, 2012, 9:26 p.m., Commit Hook wrote:
> > This review has been submitted with commit 82cf6b522e240f83d56a91a0bb43f571b1511de4 by Lambert CLARA to branch master.

if this is a bugfix, please backport it to 1.3 branch

thanks


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103833/#review10638
-----------------------------------------------------------


On Jan. 31, 2012, 9:27 p.m., Lambert CLARA wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103833/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2012, 9:27 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> When a buddy view could not be found in the same tab group than the current document, we searched in the other tab groups, which lead to the opening of another one.
> 
> 
> Diffs
> -----
> 
>   shell/documentcontroller.cpp 06189bd 
>   shell/tests/shellbuddytest.cpp 4102d02 
> 
> Diff: http://git.reviewboard.kde.org/r/103833/diff/
> 
> 
> Testing
> -------
> 
> Open a classA.h, classA.cpp, and main.cpp
> Then split vertical the main.cpp file, and close it from the left to get classA.h, classA.cpp | main.cpp
> Then after giving the focus to main.cpp, try to open classA.h with QuickOpen
> 
> This lead to :
>    classA.h, classA.h, classA.cpp | main.cpp
> 
> And now with this patch to : 
>     classA.h, classA.cpp | main.cpp, classA.h
> 
> I also modified a unit test to check for this.
> 
> 
> Thanks,
> 
> Lambert CLARA
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120215/b497531b/attachment.html>