Review Request: Bug 274299 - JJ: explanation on failed snippet name validation required

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103904/#review10481
-----------------------------------------------------------

Ship it!


one small wording issue, but thanks for the patch! please attach (i.e. file upload) it as created by "git format-patch"

thanks!


plugins/snippet/editsnippet.cpp
<http://git.reviewboard.kde.org/r/103904/#comment8587>

    I think "must not" would be more appropriate though a native speaker could make sure (if you are one, then ignore this comment :))


- Milian Wolff


On Feb. 9, 2012, 4:50 p.m., Ghislain Mary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103904/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2012, 4:50 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Show a warning message in a KMessageWidget if a space character is entered in the snippet name line edit.
> 
> 
> This addresses bug 274299.
>     http://bugs.kde.org/show_bug.cgi?id=274299
> 
> 
> Diffs
> -----
> 
>   plugins/snippet/editsnippet.cpp 732c52a71967ff6d2eea131f854d92f3f2b19ccf 
>   plugins/snippet/editsnippet.ui bb48e5e8570e37e2b53a2b69971d76ee201f0742 
> 
> Diff: http://git.reviewboard.kde.org/r/103904/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ghislain Mary
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120210/c48d2860/attachment.html>