[PATCH] Prevent crash in Mac OS X when opening project

Milian Wolff mail at milianw.de
Sun Feb 5 18:13:58 UTC 2012


On Monday 30 January 2012 11:54:33 Jens Bäckman wrote:
> ---
>  projectmanagers/cmake/cmakemanager.cpp |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/projectmanagers/cmake/cmakemanager.cpp
> b/projectmanagers/cmake/cmakemanager.cpp index 2b38fac..5ed7875 100644
> --- a/projectmanagers/cmake/cmakemanager.cpp
> +++ b/projectmanagers/cmake/cmakemanager.cpp
> @@ -859,7 +859,8 @@ QList<KDevelop::ProjectFolderItem*> CMakeManager::parse(
> KDevelop::ProjectFolder
> a->defineVariables(targetProps["COMPILE_DEFINITIONS"]);
> 
>              DescriptorAttatched*
> datt=dynamic_cast<DescriptorAttatched*>(targetItem); -           
> datt->setDescriptor(t.desc);
> +            if(datt)
> +                datt->setDescriptor(t.desc);
> 
>              KUrl::List tfiles;
>              foreach( const QString & sFile, t.files)

Hey, could you explain why this is required? I guess the dynamic cast fails 
and hence could lead to this... But any idea why?

Aleix, any input? Jens, any way to reproduce this?

bye
-- 
Milian Wolff
mail at milianw.de
http://milianw.de




More information about the KDevelop-devel mailing list