Review Request: Fix Bug 291011 (Clicking on a configuration error in the Build toolview does not bring you to the line in the CMakeLists.txt file)

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108024/#review24270
-----------------------------------------------------------

Ship it!


in the "broken" case I can still jump to the error in line 14, no? i.e. the properly highlighted line is still clickable, no?

if so - then this is a good improvement and you can go for it.

thanks!

- Milian Wolff


On Dec. 30, 2012, 3:26 p.m., Morten Volden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108024/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2012, 3:26 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This patch fixes Bug 291011 (Clicking on a configuration error in the Build toolview does not bring you to the line in the CMakeLists.txt file). 
> 
> One thing tough: It seems that cmake is not consistent with regard to the order of printing out lines (for example, see the screen shots below). This means that in the (rare?) cases where the error is the first thing printed, it is not possible to jump to the error. This is because there has been no action item first telling the filtering strategy in what directory to look. 
> 
> Input on how to deal with this scenario is most welcome.
> 
> 
> This addresses bug 291011.
>     http://bugs.kde.org/show_bug.cgi?id=291011
> 
> 
> Diffs
> -----
> 
>   outputview/outputfilteringstrategies.cpp cccc026 
>   outputview/tests/filteringstrategytest.cpp bcd5b78 
>   outputview/tests/testlinebuilderfunctions.h 3d264f7 
> 
> Diff: http://git.reviewboard.kde.org/r/108024/diff/
> 
> 
> Testing
> -------
> 
> Added a few cmake configure test cases to filteringstrategytest.
> 
> 
> Screenshots
> -----------
> 
> Filtering went well
>   http://git.reviewboard.kde.org/r/108024/s/941/
> Not possible to jump to error
>   http://git.reviewboard.kde.org/r/108024/s/942/
> 
> 
> Thanks,
> 
> Morten Volden
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121230/ee64ed6d/attachment.html>